From 3cd47a1b4d78af8c75cf88dce7810cdfea8b1815 Mon Sep 17 00:00:00 2001 From: kyuuseiryuu Date: Wed, 25 Mar 2026 22:35:59 +0900 Subject: [PATCH] fix(services): correct log messages and error handling in event services - Capitalize 'Event' in debug logs for consistency - Fix syntax error in EventWatchSchedule debug message (removed trailing backtick) - Upgrade subscription error logging from debug to error level for better visibility - Standardize event URL format in match detail logs These changes improve logging accuracy and ensure critical subscription errors are not missed. --- src/schedules/EventWatchSchedule.ts | 4 ++-- src/services/EventSubscribeService.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/schedules/EventWatchSchedule.ts b/src/schedules/EventWatchSchedule.ts index 1ea3791..76d3d57 100644 --- a/src/schedules/EventWatchSchedule.ts +++ b/src/schedules/EventWatchSchedule.ts @@ -34,7 +34,7 @@ export class EventWatchSchedule implements Schedule { const oldPlayers = await redis.get(key).then(s => s ? JSON.parse(s) as Player[] : []); await redis.set(key, JSON.stringify(event.players)); if (oldPlayers.length === 0) { - console.debug('event first time watch, skip compare. event: %s - %s', event.eventId, event.title); + console.debug('Event first time watch, skip compare. event: %s - %s', event.eventId, event.title); return; } const playerMap = new Map(oldPlayers.map(e => [e.uid, e])); @@ -45,7 +45,7 @@ export class EventWatchSchedule implements Schedule { const removedPlayers = diff.deletedList.map(e => playerMap.get(e) as Player); const addedPlayers = diff.newMemberList.map(e => playerMap.get(e) as Player); if (!removedPlayers.length && !addedPlayers.length) { - console.debug('No change detected in event: %s - %s`,', event.eventId, event.title); + console.debug('No change detected in event: %s - %s,', event.eventId, event.title); return; } const title = `${event.title} 人员变动`; diff --git a/src/services/EventSubscribeService.ts b/src/services/EventSubscribeService.ts index a6ab61e..23bfb5a 100644 --- a/src/services/EventSubscribeService.ts +++ b/src/services/EventSubscribeService.ts @@ -7,7 +7,7 @@ export class EventSubscribeService { const success = await prisma.eventSubs.create({ data: { logto_uid: user, event_id: event }}) .then(() => true) .catch(e => { - console.debug('Subscribe user: %s, event: %s, error: %s', user, event, e); + console.error('Subscribe user: %s, event: %s, error: %s', user, event, e); return false; }); return success; @@ -67,7 +67,7 @@ export class EventSubscribeService { const details: EventDetail[] = []; for (const e of beforeEvents) { const result = await KaiqiuService.getMatchDetail(e.eventId, true) - console.debug('Get match detail: %s - %s, url: %s', e.title, e.eventId, e.url) + console.debug('Get match detail: %s - %s, url: %s', e.title, e.eventId, `https://tt.ksr.la/event/${e.eventId}`) details.push(result); } return details;